chrome/browser/chromeos/login/login_utils.cc - Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_utils.cc

Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/login_utils.cc

diff --git a/chrome/browser/chromeos/login/login_utils.cc b/chrome/browser/chromeos/login/login_utils.cc

index 42e3d375ef0b1466c1bfc095bdc170d77fdf3c11..1ff12613c95e23c4a48bc0096c3b8661ddb5f84f 100644

--- a/chrome/browser/chromeos/login/login_utils.cc

+++ b/chrome/browser/chromeos/login/login_utils.cc

@@ -532,8 +532,10 @@ class WarmingObserver : public NetworkLibrary::NetworkManagerObserver {

netlib->AddNetworkManagerObserver(this);

}

+ virtual ~WarmingObserver() {}

// If we're now connected, prewarm the auth url.

- void OnNetworkManagerChanged(NetworkLibrary* netlib) {

+ virtual void OnNetworkManagerChanged(NetworkLibrary* netlib) {

if (netlib->Connected()) {

const int kConnectionsNeeded = 1;

chrome_browser_net::PreconnectOnUIThread(