Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 6995026: Revert 84802 - Disable ICF for Valgrind/ThreadSanitizer Release builds (Closed)

Created:
9 years, 7 months ago by bradn
Modified:
9 years, 7 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 84802 - Disable ICF for Valgrind/ThreadSanitizer Release builds With ICF the linker merges identical functions into one block of assembly, which leads to a) wrong symbols for some functions - which is debugger/Valgrind-unfriendly b) all ThreadSanitizer annotations end up being one function which makes TSan crazy. Since we run release code (with -O1 -g) on Valgrind bots, we have to disable ICF if release_valgrind_build!=0. BUG=82114 TEST=linux_tsan trybot goes green Review URL: http://codereview.chromium.org/6991009 TBR=timurrrr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
9 years, 7 months ago (2011-05-10 17:33:59 UTC) #1
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-10 17:35:47 UTC) #2
LGTM.
Sorry for breaking this in the first place... :(

Powered by Google App Engine
This is Rietveld 408576698