Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 6991009: Disable ICF for Valgrind/ThreadSanitizer Release builds (Closed)

Created:
9 years, 7 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, Alexander Potapenko, Lei Zhang
Visibility:
Public.

Description

Disable ICF for Valgrind/ThreadSanitizer Release builds With ICF the linker merges identical functions into one block of assembly, which leads to a) wrong symbols for some functions - which is debugger/Valgrind-unfriendly b) all ThreadSanitizer annotations end up being one function which makes TSan crazy. Since we run release code (with -O1 -g) on Valgrind bots, we have to disable ICF if release_valgrind_build!=0. BUG=82114 TEST=linux_tsan trybot goes green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84802

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-10 13:11:57 UTC) #1
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-10 15:40:11 UTC) #2
Evan Martin
LGTM, can you include a short snippet in the commit message describing why you're making ...
9 years, 7 months ago (2011-05-10 15:45:01 UTC) #3
Timur Iskhodzhanov
Done. Can you please review the comment then?
9 years, 7 months ago (2011-05-10 15:51:53 UTC) #4
Evan Martin
9 years, 7 months ago (2011-05-10 15:59:26 UTC) #5
LGTM++

On Tue, May 10, 2011 at 8:51 AM,  <timurrrr@chromium.org> wrote:
> Done.
>
> Can you please review the comment then?
>
> http://codereview.chromium.org/6991009/
>

Powered by Google App Engine
This is Rietveld 408576698