Issue 6995006: printing: Replace "using namespace printing;" wrapping the tests around "namespace printing { ... }"

Issue 6995006: printing: Replace "using namespace printing;" wrapping the tests around "namespace printing { ... }" (Closed)

Created:
9 years, 7 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

printing: Replace "using namespace printing;" wrapping the tests around "namespace printing { ... }" BUG=82078 TEST=printing_unittests R=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84782

Patch Set 2 : use namespace printing instead ;) #

Total comments: 3

Patch Set 3 : remove unnamed namespace #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	printing/units_unittest.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I think you can just put the entire test in namespace printing { }

9 years, 7 months ago (2011-05-10 01:02:53 UTC) #2

Lei Zhang

See base/string_number_conversions_unittest.cc, base/shared_memory_unittest.cc, etc.

9 years, 7 months ago (2011-05-10 01:04:02 UTC) #3

tfarina

On 2011/05/10 01:02:53, Lei Zhang wrote: > I think you can just put the entire ...

9 years, 7 months ago (2011-05-10 01:06:50 UTC) #4

Lei Zhang

http://codereview.chromium.org/6995006/diff/5001/printing/units_unittest.cc File printing/units_unittest.cc (right): http://codereview.chromium.org/6995006/diff/5001/printing/units_unittest.cc#newcode10 printing/units_unittest.cc:10: namespace { I don't think you need the anonymous ...

9 years, 7 months ago (2011-05-10 01:17:02 UTC) #5

tfarina

9 years, 7 months ago (2011-05-10 01:18:47 UTC) #6

tfarina

9 years, 7 months ago (2011-05-10 01:25:48 UTC) #8

http://codereview.chromium.org/6995006/diff/5001/printing/units_unittest.cc
File printing/units_unittest.cc (right):

http://codereview.chromium.org/6995006/diff/5001/printing/units_unittest.cc#n...
printing/units_unittest.cc:10: namespace {
On 2011/05/10 01:17:03, Lei Zhang wrote:
> I don't think you need the anonymous namespace here?

Removed.

Expand Messages | Collapse Messages