printing/units_unittest.cc - Issue 6995006: printing: Replace "using namespace printing;" wrapping the tests around "namespace printing { ... }"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/units_unittest.cc

Issue 6995006: printing: Replace "using namespace printing;" wrapping the tests around "namespace printing { ... }" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove unnamed namespace Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/units_unittest.cc

diff --git a/printing/units_unittest.cc b/printing/units_unittest.cc

index 4b7f4bf52fef4483eea56d437bd9e30ad82d3a89..fe160b3f405096496b51a1ec3a0420cfdc88d56e 100644

--- a/printing/units_unittest.cc

+++ b/printing/units_unittest.cc

@@ -6,7 +6,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "testing/gtest/include/gtest/gtest-spi.h"

-using namespace printing;

+namespace printing {

TEST(UnitsTest, Convertions) {

EXPECT_EQ(100, ConvertUnit(100, 100, 100));

@@ -59,3 +59,5 @@ TEST(UnitsTest, Convertions) {

EXPECT_EQ(8, ConvertPixelsToPoint(10));

EXPECT_EQ(0, ConvertPixelsToPoint(0));

}

+} // namespace printing

« no previous file with comments | « no previous file | no next file » | no next file with comments »