Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 6993037: Ensure address bar is reset after a redirect turns into a download. (Closed)

Created:
9 years, 6 months ago by Charlie Reis
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), brettw-cc_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Ensure address bar is reset after a redirect turns into a download. BUG=83031 TEST=NavigationControllerTest.LoadURL_RedirectAbortCancelsPending Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88886

Patch Set 1 #

Patch Set 2 : Fix test failure on Windows. #

Total comments: 4

Patch Set 3 : Update comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -6 lines) Patch
M content/browser/tab_contents/navigation_controller_unittest.cc View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Charlie Reis
Here's an attempt to fix the issue in 83031. It means we'll cancel the pending ...
9 years, 6 months ago (2011-06-04 00:40:12 UTC) #1
Charlie Reis
I just got around to fixing a failure on the Windows try bot, so this ...
9 years, 6 months ago (2011-06-07 23:52:33 UTC) #2
brettw
LGTM, I think this approach sounds fine. http://codereview.chromium.org/6993037/diff/2001/content/browser/tab_contents/navigation_controller_unittest.cc File content/browser/tab_contents/navigation_controller_unittest.cc (right): http://codereview.chromium.org/6993037/diff/2001/content/browser/tab_contents/navigation_controller_unittest.cc#newcode485 content/browser/tab_contents/navigation_controller_unittest.cc:485: ViewHostMsg_DidRedirectProvisionalLoad(0, // ...
9 years, 6 months ago (2011-06-12 12:44:56 UTC) #3
Charlie Reis
http://codereview.chromium.org/6993037/diff/2001/content/browser/tab_contents/navigation_controller_unittest.cc File content/browser/tab_contents/navigation_controller_unittest.cc (right): http://codereview.chromium.org/6993037/diff/2001/content/browser/tab_contents/navigation_controller_unittest.cc#newcode485 content/browser/tab_contents/navigation_controller_unittest.cc:485: ViewHostMsg_DidRedirectProvisionalLoad(0, // routing_id On 2011/06/12 12:44:56, brettw wrote: > ...
9 years, 6 months ago (2011-06-13 17:46:48 UTC) #4
brettw
9 years, 6 months ago (2011-06-13 17:48:42 UTC) #5
New comment sounds fine. I can't think of any other problems, though there are
probably many. LGTM.

Powered by Google App Engine
This is Rietveld 408576698