Allow closures to be optimized if outer contexts that call eval are all in strict mode.

Allow closures to be optimized if outer contexts that call eval are all in strict mode.


R=kmillikin@chromium.org
BUG=
TEST=mjsunit/compiler/eval-introduced-closure.js

Committed: http://code.google.com/p/v8/source/detail?r=7853

[Mads Ager (chromium), 2011-05-11 09:15:53]

Redirecting to Florian since Kevin is busy. :-)

[fschneider, 2011-05-11 10:35:11]

LGTM.

http://codereview.chromium.org/6993008/diff/1/src/contexts.cc
File src/contexts.cc (right):

http://codereview.chromium.org/6993008/diff/1/src/contexts.cc#newcode262
src/contexts.cc:262: if (context->IsGlobalContext()) follow_chains = false;
small simplification?

while (true) {
  ...

  if (context->IsGlobalContext()) break;
  ...
}

http://codereview.chromium.org/6993008/diff/1/src/scopes.cc
File src/scopes.cc (right):

http://codereview.chromium.org/6993008/diff/1/src/scopes.cc#newcode880
src/scopes.cc:880: (scope_calls_eval_ && !is_strict_mode()) ||
outer_scope_calls_non_strict_eval_;
Long line.

[Mads Ager (chromium), 2011-05-11 11:24:11]

http://codereview.chromium.org/6993008/diff/1/src/contexts.cc
File src/contexts.cc (right):

http://codereview.chromium.org/6993008/diff/1/src/contexts.cc#newcode262
src/contexts.cc:262: if (context->IsGlobalContext()) follow_chains = false;
On 2011/05/11 10:35:11, fschneider wrote:
> small simplification?
> 
> while (true) {
>   ...
> 
>   if (context->IsGlobalContext()) break;
>   ...
> }

Done.

http://codereview.chromium.org/6993008/diff/1/src/scopes.cc
File src/scopes.cc (right):

http://codereview.chromium.org/6993008/diff/1/src/scopes.cc#newcode880
src/scopes.cc:880: (scope_calls_eval_ && !is_strict_mode()) ||
outer_scope_calls_non_strict_eval_;
On 2011/05/11 10:35:11, fschneider wrote:
> Long line.

Done.