Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/compiler.cc

Issue 6993008: Allow closures to be optimized if outer contexts that call eval are all in strict mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/contexts.h » ('j') | src/contexts.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 osr_ast_id_(AstNode::kNoNumber) { 92 osr_ast_id_(AstNode::kNoNumber) {
93 Initialize(BASE); 93 Initialize(BASE);
94 } 94 }
95 95
96 96
97 void CompilationInfo::DisableOptimization() { 97 void CompilationInfo::DisableOptimization() {
98 bool is_optimizable_closure = 98 bool is_optimizable_closure =
99 FLAG_optimize_closures && 99 FLAG_optimize_closures &&
100 closure_.is_null() && 100 closure_.is_null() &&
101 !scope_->HasTrivialOuterContext() && 101 !scope_->HasTrivialOuterContext() &&
102 !scope_->outer_scope_calls_eval() && 102 !scope_->outer_scope_calls_non_strict_eval() &&
103 !scope_->inside_with(); 103 !scope_->inside_with();
104 SetMode(is_optimizable_closure ? BASE : NONOPT); 104 SetMode(is_optimizable_closure ? BASE : NONOPT);
105 } 105 }
106 106
107 107
108 // Determine whether to use the full compiler for all code. If the flag 108 // Determine whether to use the full compiler for all code. If the flag
109 // --always-full-compiler is specified this is the case. For the virtual frame 109 // --always-full-compiler is specified this is the case. For the virtual frame
110 // based compiler the full compiler is also used if a debugger is connected, as 110 // based compiler the full compiler is also used if a debugger is connected, as
111 // the code from the full compiler supports mode precise break points. For the 111 // the code from the full compiler supports mode precise break points. For the
112 // crankshaft adaptive compiler debugging the optimized code is not possible at 112 // crankshaft adaptive compiler debugging the optimized code is not possible at
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 shared->DebugName())); 783 shared->DebugName()));
784 } 784 }
785 } 785 }
786 786
787 GDBJIT(AddCode(Handle<String>(shared->DebugName()), 787 GDBJIT(AddCode(Handle<String>(shared->DebugName()),
788 Handle<Script>(info->script()), 788 Handle<Script>(info->script()),
789 Handle<Code>(info->code()))); 789 Handle<Code>(info->code())));
790 } 790 }
791 791
792 } } // namespace v8::internal 792 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/contexts.h » ('j') | src/contexts.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698