Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 6992052: Revert 86551 (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns ou... (Closed)

Created:
9 years, 7 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 86551 (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) - grit_info: Explicitly make __file__ relative to the current directory. __file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`, but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`. And that confuses the xcode project generator, which will complain about hash collisions if these paths are serialized in absolute form. BUG=none TEST=none Review URL: http://codereview.chromium.org/7066030 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/grit/grit_info.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
9 years, 7 months ago (2011-05-25 02:35:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698