grit_info: Explicitly make __file__ relative to the current directory.

grit_info: Explicitly make __file__ relative to the current directory.

__file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`,
but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`.
And that confuses the xcode project generator, which will complain about hash
collisions if these paths are serialized in absolute form.

BUG=82230
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86551

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86647

[Nico, 2011-05-24 19:35:40]

"I understand now why it's broken, but I don't understand how it ever worked
before."

[Mark Mentovai, 2011-05-24 20:12:46]

I defer to Tony.

[tony, 2011-05-24 20:28:05]

http://codereview.chromium.org/7066030/diff/1/tools/grit/grit_info.py
File tools/grit/grit_info.py (right):

http://codereview.chromium.org/7066030/diff/1/tools/grit/grit_info.py#newcode69
tools/grit/grit_info.py:69: grit_root_dir =
os.path.relpath(os.path.dirname(__file__), os.getcwd())
os.path.relpath was added in python 2.6 and I think the leopard bots still use
python 2.5.  Maybe we no longer build on leopard?

[Nico, 2011-05-24 21:37:20]

http://codereview.chromium.org/7066030/diff/1/tools/grit/grit_info.py
File tools/grit/grit_info.py (right):

http://codereview.chromium.org/7066030/diff/1/tools/grit/grit_info.py#newcode69
tools/grit/grit_info.py:69: grit_root_dir =
os.path.relpath(os.path.dirname(__file__), os.getcwd())
On 2011/05/24 20:28:06, tony wrote:
> os.path.relpath was added in python 2.6 and I think the leopard bots still use
> python 2.5.  Maybe we no longer build on leopard?

None of the builders use 10.5.

[tony, 2011-05-24 23:20:50]

Ok, then LGTM!

[Nico, 2011-05-25 03:04:48]

Turns out the tester bots run grit_info too, so I had to revert this.

I added a relpath implementation to the script for now…ptal :-/

[tony, 2011-05-25 03:54:14]

http://codereview.chromium.org/7066030/diff/4001/tools/grit/grit_info.py
File tools/grit/grit_info.py (right):

http://codereview.chromium.org/7066030/diff/4001/tools/grit/grit_info.py#newc...
tools/grit/grit_info.py:19: # the relpath implementation from the python source.
If you're copying code, I think you have to include the PSF license.  One
alternative would be to just write your own simpler version rather than copying.
 I think it's also OK to just inline the PSF license.

[Nico, 2011-05-25 04:48:30]

http://codereview.chromium.org/7066030/diff/4001/tools/grit/grit_info.py
File tools/grit/grit_info.py (right):

http://codereview.chromium.org/7066030/diff/4001/tools/grit/grit_info.py#newc...
tools/grit/grit_info.py:19: # the relpath implementation from the python source.
On 2011/05/25 03:54:14, tony wrote:
> If you're copying code, I think you have to include the PSF license.  One
> alternative would be to just write your own simpler version rather than
copying.
>  I think it's also OK to just inline the PSF license.

Added the license. (Using the exact same code as Python makes it obvious this
can be replaced by os.path.relpath later on. With my own function, that's not
the case.)

[tony, 2011-05-25 17:06:53]

LGTM