Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.h

Issue 6992047: Change the web store private install API to accept a localized extension name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sandboxed_extension_unpacker.h
diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.h b/chrome/browser/extensions/sandboxed_extension_unpacker.h
index 7294b3996d64ad0d7d0aa86ab81d92025b0821be..68a68d55f20874a781d20dff9b5c6e3086320314 100644
--- a/chrome/browser/extensions/sandboxed_extension_unpacker.h
+++ b/chrome/browser/extensions/sandboxed_extension_unpacker.h
@@ -25,10 +25,14 @@ class SandboxedExtensionUnpackerClient
//
// extension_root - The path to the extension root inside of temp_dir.
//
+ // original_manifest - The parsed but unmodified version of the manifest,
+ // with no modifications such as localization, etc.
+ //
// extension - The extension that was unpacked. The client is responsible
// for deleting this memory.
virtual void OnUnpackSuccess(const FilePath& temp_dir,
const FilePath& extension_root,
+ const DictionaryValue* original_manifest,
const Extension* extension) = 0;
virtual void OnUnpackFailure(const std::string& error) = 0;
@@ -54,7 +58,7 @@ class SandboxedExtensionUnpackerClient
// This class is ref-counted by each call it makes to itself on another thread,
// and by UtilityProcessHost.
//
-// Additionally, we hold a reference to our own client so that it lives at least
+ // Additionally, we hold a reference to our own client so that it lives at least
Matt Perry 2011/05/25 01:46:06 oops
asargent_no_longer_on_chrome 2011/05/25 04:42:00 Done.
// long enough to receive the result of unpacking.
//
//
@@ -189,7 +193,7 @@ class SandboxedExtensionUnpacker : public UtilityProcessHost::Client {
virtual void OnProcessCrashed(int exit_code);
void ReportFailure(FailureReason reason, const std::string& message);
- void ReportSuccess();
+ void ReportSuccess(const DictionaryValue& original_manifest);
// Overwrites original manifest with safe result from utility process.
// Returns NULL on error. Caller owns the returned object.

Powered by Google App Engine
This is Rietveld 408576698