Change the web store private install API to accept a localized extension name.

chrome/browser/extensions/sandboxed_extension_unpacker.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_SANDBOXED_EXTENSION_UNPACKER_H_
 #define CHROME_BROWSER_EXTENSIONS_SANDBOXED_EXTENSION_UNPACKER_H_
 #pragma once
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/scoped_temp_dir.h"
 #include "chrome/browser/utility_process_host.h"
 
 class DictionaryValue;
 class Extension;
 class ResourceDispatcherHost;
 
 class SandboxedExtensionUnpackerClient
     : public base::RefCountedThreadSafe<SandboxedExtensionUnpackerClient> {
  public:
   // temp_dir - A temporary directory containing the results of the extension
   // unpacking. The client is responsible for deleting this directory.
   //
   // extension_root - The path to the extension root inside of temp_dir.
   //
+  // original_manifest - The parsed but unmodified version of the manifest,
+  // with no modifications such as localization, etc.
+  //
   // extension - The extension that was unpacked. The client is responsible
   // for deleting this memory.
   virtual void OnUnpackSuccess(const FilePath& temp_dir,
                                const FilePath& extension_root,
+                               const DictionaryValue* original_manifest,
                                const Extension* extension) = 0;
   virtual void OnUnpackFailure(const std::string& error) = 0;
 
  protected:
   friend class base::RefCountedThreadSafe<SandboxedExtensionUnpackerClient>;
 
   virtual ~SandboxedExtensionUnpackerClient() {}
 };
 
 // SandboxedExtensionUnpacker unpacks extensions from the CRX format into a
 // directory. This is done in a sandboxed subprocess to protect the browser
 // process from parsing complex formats like JPEG or JSON from untrusted
 // sources.
 //
 // Unpacking an extension using this class makes minor changes to its source,
 // such as transcoding all images to PNG, parsing all message catalogs
 // and rewriting the manifest JSON. As such, it should not be used when the
 // output is not intended to be given back to the author.
 //
 //
 // Lifetime management:
 //
 // This class is ref-counted by each call it makes to itself on another thread,
 // and by UtilityProcessHost.
 //
-// Additionally, we hold a reference to our own client so that it lives at least
+ // Additionally, we hold a reference to our own client so that it lives at least

[Matt Perry, 2011/05/25 01:46:06]

oops

[asargent_no_longer_on_chrome, 2011/05/25 04:42:00]

Done.

 // long enough to receive the result of unpacking.
 //
 //
 // NOTE: This class should only be used on the file thread.
 class SandboxedExtensionUnpacker : public UtilityProcessHost::Client {
  public:
   // The size of the magic character sequence at the beginning of each crx
   // file, in bytes. This should be a multiple of 4.
   static const size_t kExtensionHeaderMagicSize = 4;
 
@@ skipping 114 matching lines @@
 
   // Starts the utility process that unpacks our extension.
   void StartProcessOnIOThread(const FilePath& temp_crx_path);
 
   // SandboxedExtensionUnpacker
   virtual void OnUnpackExtensionSucceeded(const DictionaryValue& manifest);
   virtual void OnUnpackExtensionFailed(const std::string& error_message);
   virtual void OnProcessCrashed(int exit_code);
 
   void ReportFailure(FailureReason reason, const std::string& message);
-  void ReportSuccess();
+  void ReportSuccess(const DictionaryValue& original_manifest);
 
   // Overwrites original manifest with safe result from utility process.
   // Returns NULL on error. Caller owns the returned object.
   DictionaryValue* RewriteManifestFile(const DictionaryValue& manifest);
 
   // Overwrites original files with safe results from utility process.
   // Reports error and returns false if it fails.
   bool RewriteImageFiles();
   bool RewriteCatalogFiles();
 
@@ skipping 22 matching lines @@
   bool got_response_;
 
   // The public key that was extracted from the CRX header.
   std::string public_key_;
 
   // Time at which unpacking started. Used to compute the time unpacking takes.
   base::TimeTicks unpack_start_time_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_SANDBOXED_EXTENSION_UNPACKER_H_