Changed CLB to select all text when active tab is clicked.

chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc

Index: chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc
===================================================================
--- chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc	(revision 86419)
+++ chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc	(working copy)
@@ -349,7 +349,9 @@
 }
 
 void CompactLocationBarViewHost::ActiveTabClicked(int index) {
-  UpdateOnTabChange(index, true);
+  // On active tab click, show the compact location bar and also select all the
+  // contents for quick editing.
+  browser_view()->SetFocusToLocationBar(true);

[MAD, 2011/05/25 00:21:18]

Feels a bit weird to have to go back to the browser view to set focus to our
location bar child... :-/

I think it might be cleaner to simply add a call to:
GetCompactLocationBarView()->SetFocusAndSelection()

What do you think?

[SteveT, 2011/05/25 04:16:42]

Agreed. I forgot that the CLBView had a method to do that directly. Just noticed
that BrowserView had the method I wanted but didn't look at the implementation
til now.

 }
 
 ////////////////////////////////////////////////////////////////////////////////