Changed CLB to select all text when active tab is clicked.

chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 331 matching lines @@
               Source<NavigationController>(&tab_contents->controller()));
         }
       } else {
         StartAutoHideTimer();
       }
     }
   }
 }
 
 void CompactLocationBarViewHost::ActiveTabClicked(int index) {
-  UpdateOnTabChange(index, true);
+  // On active tab click, show the compact location bar and also select all the
+  // contents for quick editing.
+  browser_view()->SetFocusToLocationBar(true);

[MAD, 2011/05/25 00:21:18]

Feels a bit weird to have to go back to the browser view to set focus to our
location bar child... :-/

I think it might be cleaner to simply add a call to:
GetCompactLocationBarView()->SetFocusAndSelection()

What do you think?

[SteveT, 2011/05/25 04:16:42]

Agreed. I forgot that the CLBView had a method to do that directly. Just noticed
that BrowserView had the method I wanted but didn't look at the implementation
til now.

 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // CompactLocationBarViewHost, NotificationObserver implementation:
 
 void CompactLocationBarViewHost::Observe(NotificationType type,
                                          const NotificationSource& source,
                                          const NotificationDetails& details) {
   switch (type.value) {
     case NotificationType::LOAD_STOP: {
@@ skipping 145 matching lines @@
 bool CompactLocationBarViewHost::IsCurrentTabIndex(int index) {
   return current_tab_model_index_ == index;
 }
 
 bool CompactLocationBarViewHost::IsCurrentTab(TabContents* contents) {
   TabStripModel* tab_strip_model = browser_view()->browser()->tabstrip_model();
   return tab_strip_model->ContainsIndex(current_tab_model_index_) &&
       tab_strip_model->GetTabContentsAt(current_tab_model_index_)->
           tab_contents() == contents;
 }