Issue 6992031: Fixed a crash involving popup windows in compact nav mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6992031: Fixed a crash involving popup windows in compact nav mode. (Closed)

Created:
9 years, 7 months ago by SteveT

Modified:
9 years, 7 months ago

Reviewers:
MAD

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed a crash involving popup windows in compact nav mode. BUG=83551 TEST=See 83551. Ensure that popups in compact nav mode are stable and can be clicked on without crashing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86639

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nits, comments. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

MAD

9 years, 7 months ago (2011-05-24 19:14:47 UTC) #2

LGTM... with small requests...

Thanks!

BYE
MAD

http://codereview.chromium.org/6992031/diff/1/chrome/browser/ui/views/compact...
File chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc
(right):

http://codereview.chromium.org/6992031/diff/1/chrome/browser/ui/views/compact...
chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc:93:
top_level_window_ = browser_view_->GetWidget()->GetNativeView();
Please add a DCHECK that host_ and browser_view_ are not NULL.
And one for browser_view_->GetWidget() not being NULL either...

http://codereview.chromium.org/6992031/diff/1/chrome/browser/ui/views/compact...
chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc:167: if
(browser_view_->GetBookmarkBarView() &&
Please add a comment that the bookmark bar view can be NULL in popup views for
example.

Expand Messages | Collapse Messages