Fixed a crash involving popup windows in compact nav mode.

chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 72 matching lines @@
   bool observing_;
 
   DISALLOW_COPY_AND_ASSIGN(MouseObserver);
 };
 
 MouseObserver::MouseObserver(CompactLocationBarViewHost* host,
                              BrowserView* view)
     : host_(host),
       browser_view_(view),
       observing_(false) {
   top_level_window_ = browser_view_->GetWidget()->GetNativeView();

[MAD, 2011/05/24 19:14:47]

Please add a DCHECK that host_ and browser_view_ are not NULL.
And one for browser_view_->GetWidget() not being NULL either...

 }
 
 MouseObserver::~MouseObserver() {
   StopObserving(MessageLoopForUI::current());
 }
 
 #if defined(OS_WIN)
 void MouseObserver::WillProcessMessage(const MSG& native_event) {}
 void MouseObserver::DidProcessMessage(const MSG& native_event) {
 #elif defined(OS_LINUX)
@@ skipping 53 matching lines @@
 }
 
 bool MouseObserver::HitContentArea(int x, int y) {
   gfx::Point p(x, y);
   // First, exclude the location bar as it's shown on top of
   // content area.
   if (HitOnScreen(host_->view(), p)) {
     return false;
   }
   // Treat the bookmark as a content area when it in detached mode.
-  if (browser_view_->GetBookmarkBarView()->IsDetached() &&
+  if (browser_view_->GetBookmarkBarView() &&

[MAD, 2011/05/24 19:14:47]

Please add a comment that the bookmark bar view can be NULL in popup views for
example.

+      browser_view_->GetBookmarkBarView()->IsDetached() &&
       browser_view_->IsBookmarkBarVisible() &&
       HitOnScreen(browser_view_->GetBookmarkBarView(), p)) {
     return true;
   }
   if (HitOnScreen(browser_view_->GetContentsView(), p)) {
     return true;
   }
   return false;
 }
 
@@ skipping 330 matching lines @@
 bool CompactLocationBarViewHost::IsCurrentTabIndex(int index) {
   return current_tab_model_index_ == index;
 }
 
 bool CompactLocationBarViewHost::IsCurrentTab(TabContents* contents) {
   TabStripModel* tab_strip_model = browser_view()->browser()->tabstrip_model();
   return tab_strip_model->ContainsIndex(current_tab_model_index_) &&
       tab_strip_model->GetTabContentsAt(current_tab_model_index_)->
           tab_contents() == contents;
 }