Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 6992018: Address bar is shown on pop-out extension windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review feedback. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator_browsertest.cc
diff --git a/chrome/browser/ui/browser_navigator_browsertest.cc b/chrome/browser/ui/browser_navigator_browsertest.cc
index bd717ed49fd430856a06389df2ab1edc6cbdfbff..c7d9b5f5bcaaa89a3fe267cd4bbf218d68fb3683 100644
--- a/chrome/browser/ui/browser_navigator_browsertest.cc
+++ b/chrome/browser/ui/browser_navigator_browsertest.cc
@@ -275,6 +275,29 @@ IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, Disposition_NewPopup) {
}
// This test verifies that navigating with WindowOpenDisposition = NEW_POPUP
+// from a normal Browser results in a new Browser with is_app() true.
+IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, Disposition_NewPopup_ExtensionId) {
+ browser::NavigateParams p(MakeNavigateParams());
+ p.disposition = NEW_POPUP;
+ p.extension_app_id = "extensionappid";
+ p.window_bounds = gfx::Rect(0, 0, 200, 200);
+ browser::Navigate(&p);
+ // Wait for new popup to to load and gain focus.
+ ui_test_utils::WaitForNavigationInCurrentTab(p.browser);
+
+ // Navigate() should have opened a new, focused popup window.
+ EXPECT_NE(browser(), p.browser);
+ EXPECT_TRUE(p.browser->is_type_popup());
+ EXPECT_TRUE(p.browser->is_app());
+
+ // We should have two windows, the browser() provided by the framework and the
+ // new popup window.
+ EXPECT_EQ(2u, BrowserList::size());
+ EXPECT_EQ(1, browser()->tab_count());
+ EXPECT_EQ(1, p.browser->tab_count());
+}
+
+// This test verifies that navigating with WindowOpenDisposition = NEW_POPUP
// from a normal popup results in a new Browser with TYPE_POPUP.
IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, Disposition_NewPopupFromPopup) {
// Open a popup.

Powered by Google App Engine
This is Rietveld 408576698