chrome/browser/ui/browser_navigator.cc - Issue 6992018: Address bar is shown on pop-out extension windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 6992018: Address bar is shown on pop-out extension windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review feedback. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index c109a24c2a337a2c47dcc25b32b3af6fd1eab436..d6771a53d2b1dc09f31fbecbe4660eda5c3600bd 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -186,7 +186,9 @@ Browser* GetBrowserForDisposition(browser::NavigateParams* params) {

if (profile) {

// Coerce app-style if |params->browser| or |source| represents an app.

std::string app_name;

- if (params->browser && !params->browser->app_name().empty()) {

+ if (!params->extension_app_id.empty()) {

+ app_name = params->extension_app_id;

+ } else if (params->browser && !params->browser->app_name().empty()) {

app_name = params->browser->app_name();

} else if (params->source_contents &&

params->source_contents->extension_tab_helper()->is_app()) {