Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 6992018: Address bar is shown on pop-out extension windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added tests. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/window_open_apitest.cc
diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc
index 3cd160844d67efec784f5cc2832cf9081cb395e4..cd3910325907d0eb02f1e0b5542ab44069db6575 100644
--- a/chrome/browser/extensions/window_open_apitest.cc
+++ b/chrome/browser/extensions/window_open_apitest.cc
@@ -49,6 +49,20 @@ void WaitForTabsAndPopups(Browser* browser, int num_tabs, int num_popups) {
}
}
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BrowserIsApp) {
Erik does not do reviews 2011/05/25 15:13:03 Could you add a test where the app opens a popup t
prasadt 2011/05/25 17:53:00 Done.
+ ASSERT_TRUE(LoadExtension(
+ test_data_dir_.AppendASCII("window_open").AppendASCII("browser_is_app")));
+
+ WaitForTabsAndPopups(browser(), 0, 1);
+
+ BrowserList::const_iterator iter = BrowserList::begin();
+ if (browser() == *iter)
+ ++iter;
+
+ ASSERT_FALSE(browser()->is_app());
+ ASSERT_TRUE((*iter)->is_app());
+}
+
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PopupBlockingExtension) {
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(StartTestServer());

Powered by Google App Engine
This is Rietveld 408576698