Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 6992018: Address bar is shown on pop-out extension windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added tests. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index 2870cd63831bdbca77eb3568804814e32f5e259f..12eaca46e5cea18950a2c327b3bc61b57f8fee75 100644
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -586,6 +586,7 @@ void ExtensionHost::ShowCreatedWindow(int route_id,
browser::NavigateParams params(browser, wrapper);
if (!browser)
params.profile = contents->profile();
+ params.extension_app_id = extension_id_;
Erik does not do reviews 2011/05/25 15:13:03 I forget the semantics of ShowCreatedWindow in thi
prasadt 2011/05/25 17:53:00 This is called for any URL opened with window.open
params.disposition = NEW_POPUP;
params.window_bounds = initial_pos;
params.window_action = browser::NavigateParams::SHOW_WINDOW;
« no previous file with comments | « no previous file | chrome/browser/extensions/window_open_apitest.cc » ('j') | chrome/browser/extensions/window_open_apitest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698