Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 6991010: Remove NearLabel, replacing remaining occurrences with Label (Closed)

Created:
9 years, 7 months ago by Jakob Kummerow
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove NearLabel, replacing remaining occurrences with Label TEST=compiles, existing tests pass Committed: http://code.google.com/p/v8/source/detail?r=7848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1021 lines, -1177 lines) Patch
M src/assembler.h View 1 chunk +0 lines, -51 lines 0 comments Download
M src/ia32/assembler-ia32.h View 3 chunks +0 lines, -10 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 3 chunks +0 lines, -54 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +18 lines, -9 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 11 chunks +32 lines, -34 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 7 chunks +18 lines, -16 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +4 lines, -30 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +38 lines, -9 lines 0 comments Download
M src/x64/assembler-x64.h View 3 chunks +0 lines, -10 lines 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +0 lines, -51 lines 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +16 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 14 chunks +45 lines, -48 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 7 chunks +18 lines, -16 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 15 chunks +68 lines, -807 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 18 chunks +751 lines, -8 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Here's a follow-up to what you reviewed earlier: completely remove the NearLabel class. This CL ...
9 years, 7 months ago (2011-05-10 16:09:37 UTC) #1
danno
LGTM, looks mechanically correct, although my eyeballs itch after looking at all the mechanical changes.
9 years, 7 months ago (2011-05-10 16:29:16 UTC) #2
Mads Ager (chromium)
9 years, 7 months ago (2011-05-11 05:58:31 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698