Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 6990039: Merge 82297 - Make sure that extensions can launch web urls with web safe schemes only. (Closed)

Created:
9 years, 7 months ago by Cris Neckar
Modified:
9 years, 7 months ago
Reviewers:
aarya
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 82297 - Make sure that extensions can launch web urls with web safe schemes only. Reviewed in http://codereview.chromium.org/6879047. BUG=79862 TEST=ExtensionManifestTest.AppLaunchURL Review URL: http://codereview.chromium.org/6879077 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/common/extensions/extension.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
D chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json View 1 chunk +0 lines, -9 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/launch_url_invalid_type_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/launch_url_invalid_type_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/launch_url_invalid_type_3.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Cris Neckar
9 years, 7 months ago (2011-05-23 18:46:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698