Make sure that extensions can launch web urls, create bookmark url with web safe schemes only.

Webkit Roll - r85866:r85951

[Aaron Boodman, 2011-04-19 18:29:33]

Can you add tests for these two?

For the extension.cc change, you can change extension_manifest_unittest.cc, and
for the bookmarks change, you can add something to
chrome/test/data/extensions/api_tests/bookmarks/

http://codereview.chromium.org/6879047/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/6879047/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension.cc:1217: if (!url.is_valid() ||
!policy->IsWebSafeScheme(url.scheme())) {
I think it would be better to use Extension::kValidWebExtentSchemes so that
things are consistent. You might have to parse the launch URL with URLPattern in
order to verify this.

[Erik does not do reviews, 2011-04-19 23:36:23]

I'm not sure we should do this fix.  I started a thread in the bug.

[inferno, 2011-04-19 23:51:08]

On 2011/04/19 23:36:23, Erik Kay wrote:
> I'm not sure we should do this fix.  I started a thread in the bug.

There are 2 fixes here.
1. launch_url should definitely not launch javascript: url which run in chrome
newtab context. and launching chrome:// url gives a way to exploit an xss in
chrome url.
2. for bookmarks, when they are created user knows which url they are created
for [by either making it manually or clicking the bookmark start next to a url].
when they are created through extensions, they don't know about it and also,
they don't get to know if the url in that bookmark changed [worst part is the
other bookmarks dropdown which does not show a tooltip showing the bookmark
url]. So, as a security in depth manner, chrome:// and javascript unsafe url
should not be allowed. lets see what Aaron thinks.

[Aaron Boodman, 2011-04-20 05:44:05]

The code LGTM, but please wait to commit the bookmark part until we have
consensus in the bug.