Issue 6990030: WebUI: size the cookies list according to the window height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6990030: WebUI: size the cookies list according to the window height. (Closed)

Created:
9 years, 7 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

WebUI: size the cookies list according to the window height. BUG=75678 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86247

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -5 lines)			Patch
	M	chrome/browser/resources/options/cookies_view.css	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	chrome/browser/resources/options/cookies_view.js	View	1	3 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM http://codereview.chromium.org/6990030/diff/1/chrome/browser/resources/options/cookies_view.js File chrome/browser/resources/options/cookies_view.js (right): http://codereview.chromium.org/6990030/diff/1/chrome/browser/resources/options/cookies_view.js#newcode104 chrome/browser/resources/options/cookies_view.js:104: * Handler for when the window changes size. ...

9 years, 7 months ago (2011-05-23 02:07:20 UTC) #2

Mike Mammarella

9 years, 7 months ago (2011-05-23 02:16:00 UTC) #3

http://codereview.chromium.org/6990030/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/cookies_view.js (right):

http://codereview.chromium.org/6990030/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/cookies_view.js:104: * Handler for when the
window changes size. We want to resize the cookies
On 2011/05/23 02:07:20, James Hawkins wrote:
> nit: s/We want to resize/Resize/

Done.

Expand Messages | Collapse Messages

Issue 6990030: WebUI: size the cookies list according to the window height. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages