WebUI: Add password manager search feature. Also add tooltips for the URLs.

WebUI: Add password manager search feature. Also add tooltips for the URLs.
BUG=9575, 79690
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86230

[Mike Mammarella, 2011-05-21 09:07:35]

Similar to the cookie search feature, but implemented a little differently.

[James Hawkins, 2011-05-22 00:02:58]

LGTM with nits.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager.html (right):

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.html:4: <div
id="passwords-title"><h3 i18n-content="savedPasswordsTitle"></h3></div>
For readability, can you put the <h3> block on a new line?

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.html:7: placeholder=" Search
passwords" incremental
What's the space at the beginning of the placeholder for?

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager.js (right):

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:87: queryDelayTimerId_: 0,
nit: Document this variable and move it to the top. Same for the other private
variables.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:91: * @private
nit: @private should be last.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:98: // Searching cookies
uses a timeout of 500. We use a shorter timeout
500ms?

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:100: // snappier since
users (at least I) expect that it's "less work."
nit: Remove the parenthetical.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:108: * Search passwords
using text in password-search-box.
nit: |password-search-box|.

[Mike Mammarella, 2011-05-22 00:35:10]

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager.html (right):

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.html:4: <div
id="passwords-title"><h3 i18n-content="savedPasswordsTitle"></h3></div>
On 2011/05/22 00:02:58, James Hawkins wrote:
> For readability, can you put the <h3> block on a new line?

Done.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.html:7: placeholder=" Search
passwords" incremental
On 2011/05/22 00:02:58, James Hawkins wrote:
> What's the space at the beginning of the placeholder for?

Makes it look nicer. There's a magnifying glass icon in search boxes and this
puts some space between it and the placeholder.

Though really if it's supported we should do
i18n-values="placeholder:searchPasswords" and a similar thing in the search
field for cookies, but I'd prefer to do that in a follow-up change.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager.js (right):

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:87: queryDelayTimerId_: 0,
On 2011/05/22 00:02:58, James Hawkins wrote:
> nit: Document this variable and move it to the top. Same for the other private
> variables.

Done. Also documented similar variables in cookie search.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:91: * @private
On 2011/05/22 00:02:58, James Hawkins wrote:
> nit: @private should be last.

Done.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:98: // Searching cookies
uses a timeout of 500. We use a shorter timeout
On 2011/05/22 00:02:58, James Hawkins wrote:
> 500ms?

Done.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:100: // snappier since
users (at least I) expect that it's "less work."
On 2011/05/22 00:02:58, James Hawkins wrote:
> nit: Remove the parenthetical.

Done.

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.js:108: * Search passwords
using text in password-search-box.
On 2011/05/22 00:02:58, James Hawkins wrote:
> nit: |password-search-box|.

Done.

[James Hawkins, 2011-05-22 02:03:46]

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager.html (right):

http://codereview.chromium.org/6990026/diff/4001/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager.html:7: placeholder=" Search
passwords" incremental
On 2011/05/22 00:35:11, Mike Mammarella wrote:
> On 2011/05/22 00:02:58, James Hawkins wrote:
> > What's the space at the beginning of the placeholder for?
> 
> Makes it look nicer. There's a magnifying glass icon in search boxes and this
> puts some space between it and the placeholder.
> 
> Though really if it's supported we should do
> i18n-values="placeholder:searchPasswords" and a similar thing in the search
> field for cookies, but I'd prefer to do that in a follow-up change.

Yes, please; very important for i18n. Do we do the extra space trick in other
instances of the search input?  Is there a styling solution available?