chrome/browser/resources/options/password_manager.html - Issue 6990026: WebUI: Add password manager search feature. Also add tooltips for the URLs.

Side by Side Diff: chrome/browser/resources/options/password_manager.html

Issue 6990026: WebUI: Add password manager search feature. Also add tooltips for the URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/resources/options/password_manager.css ('k') | chrome/browser/resources/options/password_manager.js » ('j') | chrome/browser/resources/options/password_manager.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="password-manager" class="page hidden">	1 <div id="password-manager" class="page hidden">

2 <h1 i18n-content="passwordsPage"></h1>	2 <h1 i18n-content="passwordsPage"></h1>

3 <h3 i18n-content="savedPasswordsTitle"></h3>	3 <div id="password-list-headers">

	4 <div id="passwords-title"><h3 i18n-content="savedPasswordsTitle"></h3></div>
	James Hawkins 2011/05/22 00:02:58 For readability, can you put the <h3> block on a n For readability, can you put the <h3> block on a new line? Mike Mammarella 2011/05/22 00:35:11 Done. Show quoted text On 2011/05/22 00:02:58, James Hawkins wrote: > For readability, can you put the <h3> block on a new line? Done.
	5 <div id="password-search-column">

	6 <input id="password-search-box" type="search"

	7 placeholder=" Search passwords" incremental
	James Hawkins 2011/05/22 00:02:58 What's the space at the beginning of the placehold What's the space at the beginning of the placeholder for? Mike Mammarella 2011/05/22 00:35:11 Makes it look nicer. There's a magnifying glass ic Show quoted text On 2011/05/22 00:02:58, James Hawkins wrote: > What's the space at the beginning of the placeholder for? Makes it look nicer. There's a magnifying glass icon in search boxes and this puts some space between it and the placeholder. Though really if it's supported we should do i18n-values="placeholder:searchPasswords" and a similar thing in the search field for cookies, but I'd prefer to do that in a follow-up change. James Hawkins 2011/05/22 02:03:46 Yes, please; very important for i18n. Do we do the Show quoted text On 2011/05/22 00:35:11, Mike Mammarella wrote: > On 2011/05/22 00:02:58, James Hawkins wrote: > > What's the space at the beginning of the placeholder for? > > Makes it look nicer. There's a magnifying glass icon in search boxes and this > puts some space between it and the placeholder. > > Though really if it's supported we should do > i18n-values="placeholder:searchPasswords" and a similar thing in the search > field for cookies, but I'd prefer to do that in a follow-up change. Yes, please; very important for i18n. Do we do the extra space trick in other instances of the search input? Is there a styling solution available?
	8 results="10" autosave="org.chromium.options.passwords.search">

	9 </div>

	10 </div>

4 <list id="saved-passwords-list" class="settings-list"></list>	11 <list id="saved-passwords-list" class="settings-list"></list>

5 <div id="saved-passwords-list-empty-placeholder"	12 <div id="saved-passwords-list-empty-placeholder"

6 class="settings-list-empty" hidden>	13 class="settings-list-empty" hidden>

7 <span i18n-content="passwordsNoPasswordsDescription"></span>	14 <span i18n-content="passwordsNoPasswordsDescription"></span>

8 <a target="_blank" i18n-content="learnMore"	15 <a target="_blank" i18n-content="learnMore"

9 i18n-values="href:passwordManagerLearnMoreURL"></a>	16 i18n-values="href:passwordManagerLearnMoreURL"></a>

10 </div>	17 </div>

11 <h3 i18n-content="passwordExceptionsTitle"></h3>	18 <h3 i18n-content="passwordExceptionsTitle"></h3>

12 <list id="password-exceptions-list" class="settings-list"></list>	19 <list id="password-exceptions-list" class="settings-list"></list>

13 <div id="password-exceptions-list-empty-placeholder" hidden	20 <div id="password-exceptions-list-empty-placeholder" hidden

14 class="settings-list-empty">	21 class="settings-list-empty">

15 <span i18n-content="passwordsNoExceptionsDescription"></span>	22 <span i18n-content="passwordsNoExceptionsDescription"></span>

16 <a target="_blank" i18n-content="learnMore"	23 <a target="_blank" i18n-content="learnMore"

17 i18n-values="href:passwordManagerLearnMoreURL"></a>	24 i18n-values="href:passwordManagerLearnMoreURL"></a>

18 </div>	25 </div>

19 </div>	26 </div>

OLD	NEW