Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: base/metrics/histogram.cc

Issue 6976044: Fix http://codereview.chromium.org/6869009 to ignore an existing object exactly once and land the... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/leak_annotations.h ('k') | net/disk_cache/stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram.cc
===================================================================
--- base/metrics/histogram.cc (revision 86987)
+++ base/metrics/histogram.cc (working copy)
@@ -14,6 +14,7 @@
#include <algorithm>
#include <string>
+#include "base/debug/leak_annotations.h"
#include "base/logging.h"
#include "base/pickle.h"
#include "base/stringprintf.h"
@@ -97,6 +98,8 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
+ if (histogram == tentative_histogram)
+ ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(HISTOGRAM, histogram->histogram_type());
@@ -791,6 +794,8 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
+ if (histogram == tentative_histogram)
+ ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(LINEAR_HISTOGRAM, histogram->histogram_type());
@@ -882,6 +887,8 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
+ if (histogram == tentative_histogram)
+ ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(BOOLEAN_HISTOGRAM, histogram->histogram_type());
@@ -929,6 +936,8 @@
tentative_histogram->SetFlags(flags);
histogram =
StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);
+ if (histogram == tentative_histogram)
+ ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322
}
DCHECK_EQ(histogram->histogram_type(), CUSTOM_HISTOGRAM);
« no previous file with comments | « base/debug/leak_annotations.h ('k') | net/disk_cache/stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698