Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6975045: touch: Always expect XInput2 availability. (Closed)

Created:
9 years, 6 months ago by sadrul
Modified:
9 years, 5 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

touch: Always expect XInput2 availability. BUG=80790 TEST=touch compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93621

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : merge with trunk #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -166 lines) Patch
M base/message_pump_x.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M base/message_pump_x.cc View 1 2 7 chunks +0 lines, -18 lines 0 comments Download
M build/linux/system.gyp View 1 2 3 1 chunk +2 lines, -19 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.cc View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +6 lines, -8 lines 0 comments Download
M ui/views/focus/accelerator_handler.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/events/event_x.cc View 1 2 13 chunks +1 line, -23 lines 0 comments Download
M views/focus/accelerator_handler.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/focus/accelerator_handler_touch.cc View 1 2 5 chunks +0 lines, -20 lines 0 comments Download
M views/touchui/touch_factory.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M views/views.gyp View 1 2 2 chunks +0 lines, -24 lines 0 comments Download
M views/widget/native_widget_gtk.cc View 1 2 5 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
9 years, 6 months ago (2011-05-31 17:28:00 UTC) #1
Evan Martin
base part LGTM
9 years, 6 months ago (2011-05-31 17:29:40 UTC) #2
Paweł Hajdan Jr.
LGTM, thank you!
9 years, 6 months ago (2011-05-31 17:48:11 UTC) #3
Ben Goodger (Google)
Cool. LGTM.
9 years, 6 months ago (2011-05-31 17:51:07 UTC) #4
Yusuke Sato
Sadrul, could you check http://code.google.com/p/chromium-os/issues/detail?id=15851#c10 and http://code.google.com/p/chromium-os/issues/detail?id=15851#c13 before checking this in? I might have to ...
9 years, 6 months ago (2011-06-02 07:25:01 UTC) #5
Yusuke Sato
http://codereview.chromium.org/6975045/diff/18/build/linux/system.gyp File build/linux/system.gyp (left): http://codereview.chromium.org/6975045/diff/18/build/linux/system.gyp#oldcode273 build/linux/system.gyp:273: 'HAVE_XINPUT2', http://src.chromium.org/viewvc/chrome?view=rev&revision=87756 also uses HAVE_XINPUT2 (to work around crbug.com/84694). ...
9 years, 6 months ago (2011-06-06 01:08:38 UTC) #6
sadrul
9 years, 6 months ago (2011-06-06 01:13:14 UTC) #7 
Yes, I am going to hold this until crbug.com/84694 is resolved.

Powered by Google App Engine
This is Rietveld 408576698