When the download folder does not exist, change the download folder to a user's "Downloads"

chrome/browser/download/save_package.cc

Index: chrome/browser/download/save_package.cc
diff --git a/chrome/browser/download/save_package.cc b/chrome/browser/download/save_package.cc
index 2ed57397da3ac0a2713049e04c2aef170b7d46fe..fc165a28df31a274d006e0763042b616520d8795 100644
--- a/chrome/browser/download/save_package.cc
+++ b/chrome/browser/download/save_package.cc
@@ -11,6 +11,7 @@
 #include "base/i18n/file_util_icu.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
+#include "base/path_service.h"
 #include "base/stl_util-inl.h"
 #include "base/string_piece.h"
 #include "base/string_split.h"
@@ -1275,10 +1276,12 @@ void SavePackage::CreateDirectoryOnFileThread(
   FilePath save_dir;
   // If the default html/websites save folder doesn't exist...
   if (!file_util::DirectoryExists(website_save_dir)) {
-    // If the default download dir doesn't exist, create it.
+    // If the default download folder doesn't exist,
+    // default to the user's "My Documents" folder.
     if (!file_util::DirectoryExists(download_save_dir))
-      file_util::CreateDirectory(download_save_dir);
-    save_dir = download_save_dir;
+      PathService::Get(chrome::DIR_USER_DOCUMENTS, &save_dir);

[Paweł Hajdan Jr., 2011/05/13 09:16:22]

Please check the return value.

[haraken1, 2011/05/17 04:29:05]

Done.

+    else

[Paweł Hajdan Jr., 2011/05/13 09:16:22]

Now this is a double-negation. Please put the "true" branch first, i.e.

if (file_util::DirectoryExists(...)) {
  save_dir = download_save_dir;
} else {
  ...
}

[haraken1, 2011/05/17 04:29:05]

Done.

+      save_dir = download_save_dir;
   } else {
     // If it does exist, use the default save dir param.
     save_dir = website_save_dir;