When the download folder does not exist, change the download folder to a user's "Downloads"

chrome/browser/download/save_package.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/save_package.h"
 
 #include <algorithm>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
+#include "base/path_service.h"
 #include "base/stl_util-inl.h"
 #include "base/string_piece.h"
 #include "base/string_split.h"
 #include "base/sys_string_conversions.h"
 #include "base/task.h"
 #include "base/threading/thread.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_item.h"
 #include "chrome/browser/download/download_item_model.h"
@@ skipping 1244 matching lines @@
           website_save_dir, download_save_dir, mime_type));
 }
 
 void SavePackage::CreateDirectoryOnFileThread(
     const FilePath& website_save_dir,
     const FilePath& download_save_dir,
     const std::string& mime_type) {
   FilePath save_dir;
   // If the default html/websites save folder doesn't exist...
   if (!file_util::DirectoryExists(website_save_dir)) {
-    // If the default download dir doesn't exist, create it.
+    // If the default download folder doesn't exist,
+    // default to the user's "My Documents" folder.
     if (!file_util::DirectoryExists(download_save_dir))
-      file_util::CreateDirectory(download_save_dir);
-    save_dir = download_save_dir;
+      PathService::Get(chrome::DIR_USER_DOCUMENTS, &save_dir);

[Paweł Hajdan Jr., 2011/05/13 09:16:22]

Please check the return value.

[haraken1, 2011/05/17 04:29:05]

Done.

+    else

[Paweł Hajdan Jr., 2011/05/13 09:16:22]

Now this is a double-negation. Please put the "true" branch first, i.e.

if (file_util::DirectoryExists(...)) {
  save_dir = download_save_dir;
} else {
  ...
}

[haraken1, 2011/05/17 04:29:05]

Done.

+      save_dir = download_save_dir;
   } else {
     // If it does exist, use the default save dir param.
     save_dir = website_save_dir;
   }
 
   bool can_save_as_complete = CanSaveAsComplete(mime_type);
   FilePath suggested_filename = GetSuggestedNameForSaveAs(can_save_as_complete,
                                                           mime_type);
   FilePath::StringType pure_file_name =
       suggested_filename.RemoveExtension().BaseName().value();
@@ skipping 172 matching lines @@
 }
 
 // SelectFileDialog::Listener interface.
 void SavePackage::FileSelected(const FilePath& path,
                                int index, void* params) {
   ContinueSave(path, index);
 }
 
 void SavePackage::FileSelectionCanceled(void* params) {
 }