net: Add NET_API to net/base

net/base/upload_data_stream.h

Index: net/base/upload_data_stream.h
===================================================================
--- net/base/upload_data_stream.h	(revision 85332)
+++ net/base/upload_data_stream.h	(working copy)
@@ -7,6 +7,7 @@
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
+#include "net/base/net_api.h"
 #include "net/base/upload_data.h"
 
 namespace net {
@@ -14,7 +15,7 @@
 class FileStream;
 class IOBuffer;
 
-class UploadDataStream {
+class NET_API UploadDataStream {
  public:
   ~UploadDataStream();
 
@@ -62,7 +63,7 @@
   // returns true only after the data in buf() has been consumed.
   bool IsOnLastChunk() const;
 
-#if defined(UNIT_TEST)
+#if defined(UNIT_TEST) || defined(NET_DLL)

[wtc, 2011/05/16 20:55:17]

Perhaps we should just remove this ifdef?

Could you explain why NET_DLL also needs this method?

[rvargas (doing something else), 2011/05/16 22:41:56]

If the compiler, while building the dll doesn't "see" this line, it won't be
part of the dll, and the test won't be able to find it.

I removed the guards on all UNIT_TEST that are required in order to build.

   static void set_merge_chunks(bool merge) { merge_chunks_ = merge; }

[wtc, 2011/05/16 23:07:13]

If appropriate, add a comment to say this method is intended
for unit tests only.

 #endif