net: Add NET_API to net/base

net/base/upload_data_stream.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_UPLOAD_DATA_STREAM_H_
 #define NET_BASE_UPLOAD_DATA_STREAM_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
+#include "net/base/net_api.h"
 #include "net/base/upload_data.h"
 
 namespace net {
 
 class FileStream;
 class IOBuffer;
 
-class UploadDataStream {
+class NET_API UploadDataStream {
  public:
   ~UploadDataStream();
 
   // Returns a new instance of UploadDataStream if it can be created and
   // initialized successfully. If not, NULL will be returned and the error
   // code will be set if the output parameter error_code is not empty.
   static UploadDataStream* Create(UploadData* data, int* error_code);
 
   // Returns the stream's buffer and buffer length.
   IOBuffer* buf() const { return buf_; }
@@ skipping 27 matching lines @@
   // Returns whether there is no more data to read, regardless of whether
   // position < size.
   bool eof() const { return eof_; }
 
   // Returns whether the data available in buf() includes the last chunk in a
   // chunked data stream. This method returns true once the final chunk has been
   // placed in the IOBuffer returned by buf(), in contrast to eof() which
   // returns true only after the data in buf() has been consumed.
   bool IsOnLastChunk() const;
 
-#if defined(UNIT_TEST)
+#if defined(UNIT_TEST) || defined(NET_DLL)

[wtc, 2011/05/16 20:55:17]

Perhaps we should just remove this ifdef?

Could you explain why NET_DLL also needs this method?

[rvargas (doing something else), 2011/05/16 22:41:56]

If the compiler, while building the dll doesn't "see" this line, it won't be
part of the dll, and the test won't be able to find it.

I removed the guards on all UNIT_TEST that are required in order to build.

   static void set_merge_chunks(bool merge) { merge_chunks_ = merge; }

[wtc, 2011/05/16 23:07:13]

If appropriate, add a comment to say this method is intended
for unit tests only.

 #endif
 
  private:
   enum { kBufSize = 16384 };
 
   // Protects from public access since now we have a static creator function
   // which will do both creation and initialization and might return an error.
   explicit UploadDataStream(UploadData* data);
 
   // Fills the buffer with any remaining data and sets eof_ if there was nothing
@@ skipping 35 matching lines @@
   // TODO(satish): Remove this once we have a better way to unit test POST
   // requests with chunked uploads.
   static bool merge_chunks_;
 
   DISALLOW_COPY_AND_ASSIGN(UploadDataStream);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_UPLOAD_DATA_STREAM_H_