Issue 6969057: Support for re-using open tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6969057: Support for re-using open tabs (Closed)

Created:
9 years, 7 months ago by achuithb

Modified:
9 years, 6 months ago

Reviewers:
xiyuan

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Support for re-using open tabs BUG=chromium-os:15368 TEST=Click on 'Show All Download' link in download panel or any downloaded file. Instead of multiple windows, the same window should get selected and become active. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86658

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -27 lines)			Patch
	M	chrome/browser/ui/webui/active_downloads_ui.cc	View	1 2 3 4 5 6	6 chunks	+24 lines, -27 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

xiyuan

http://codereview.chromium.org/6969057/diff/1001/chrome/browser/ui/webui/active_downloads_ui.cc File chrome/browser/ui/webui/active_downloads_ui.cc (right): http://codereview.chromium.org/6969057/diff/1001/chrome/browser/ui/webui/active_downloads_ui.cc#newcode412 chrome/browser/ui/webui/active_downloads_ui.cc:412: kPopupHeight)); nit: align the args. http://codereview.chromium.org/6969057/diff/1001/chrome/browser/ui/webui/active_downloads_ui.cc#newcode415 chrome/browser/ui/webui/active_downloads_ui.cc:415: browser->command_updater()->UpdateCommandEnabled(IDC_OPEN_FILE, false); ...

9 years, 7 months ago (2011-05-13 16:34:28 UTC) #2

Thanks!

On 2011/05/25 16:49:28, xiyuan wrote:
> LGTM

Expand Messages | Collapse Messages