Support for re-using open tabs

chrome/browser/ui/webui/active_downloads_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/active_downloads_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/string_piece.h"
 #include "base/string_util.h"
 #include "base/threading/thread.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
+#include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/download/download_item.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 362 matching lines @@
     browser = Browser::CreateForApp(Browser::TYPE_PANEL, kActiveDownloadAppName,
                                     gfx::Size(), profile);
 
     browser::NavigateParams params(
         browser,
         GURL(chrome::kChromeUIActiveDownloadsURL),
         PageTransition::LINK);
     params.disposition = NEW_FOREGROUND_TAB;
     browser::Navigate(&params);
 
+    DCHECK_EQ(browser, params.browser);
     // TODO(beng): The following two calls should be automatic by Navigate().
-    params.browser->window()->SetBounds(gfx::Rect(kPopupLeft,
+    browser->window()->SetBounds(gfx::Rect(kPopupLeft,
                                                   kPopupTop,
                                                   kPopupWidth,
                                                   kPopupHeight));

[xiyuan, 2011/05/13 16:34:28]

nit: align the args.

-    params.browser->window()->Show();
-  } else {
-    browser->window()->Show();
+
+    // Disallow Open File.
+    browser->command_updater()->UpdateCommandEnabled(IDC_OPEN_FILE, false);

[xiyuan, 2011/05/13 16:34:28]

This is not a reliable way to disable a command. Suggest to include this case in
Browser::UpdateOpenFileState.

   }
 
+  browser->window()->Show();
   return browser;
 }
 
 Browser* ActiveDownloadsUI::GetPopup(Profile* profile) {
   for (BrowserList::const_iterator it = BrowserList::begin();
        it != BrowserList::end();
        ++it) {
     if ((*it)->is_type_panel() && (*it)->is_app()) {
       TabContents* tab_contents = (*it)->GetSelectedTabContents();
       DCHECK(tab_contents);
       if (!tab_contents)
         continue;
       const GURL& url = tab_contents->GetURL();
 
       if (url.SchemeIs(chrome::kChromeUIScheme) &&
           url.host() == chrome::kChromeUIActiveDownloadsHost &&
           (*it)->profile() == profile) {
         return (*it);
       }
     }
   }
   return NULL;
 }