Simplify the disable_pie logic.

Simplify the disable_pie logic.

Since we only use the variable in one place, move its definition
into that one place.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85162

[Evan Martin, 2011-05-12 18:31:40]

(I'm looking to turn on PIE for Linux Chrome, so I was reading this code and
thought I'd refactor it slightly.)

[raymes, 2011-05-12 19:03:02]

On 2011/05/12 18:31:40, Evan Martin wrote:
> (I'm looking to turn on PIE for Linux Chrome, so I was reading this code and
> thought I'd refactor it slightly.)

LGTM

I filed http://code.google.com/p/chromium-os/issues/detail?id=15266 to track the
bug and the removal of disable_pie. If we want it to stick around as a permanent
feature it probably needs some tweaks and removal of the TODO. If you're looking
at enabling pie by default, I'm guessing it might be a useful option.

[rkc, 2011-05-12 19:08:28]

We want to keep the option to enable this for other executables also; for
example browser_tests or ui_tests. In fact, it might be a good idea to go ahead
and add it to at least browser_tests since that's one place debugging would
really be needed.


On 2011/05/12 19:03:02, raymes wrote:
> On 2011/05/12 18:31:40, Evan Martin wrote:
> > (I'm looking to turn on PIE for Linux Chrome, so I was reading this code and
> > thought I'd refactor it slightly.)
> 
> LGTM
> 
> I filed http://code.google.com/p/chromium-os/issues/detail?id=15266 to track
the
> bug and the removal of disable_pie. If we want it to stick around as a
permanent
> feature it probably needs some tweaks and removal of the TODO. If you're
looking
> at enabling pie by default, I'm guessing it might be a useful option.

[Evan Martin, 2011-05-12 19:09:49]

On 2011/05/12 19:08:28, Rahul Chaturvedi wrote:
> We want to keep the option to enable this for other executables also; for
> example browser_tests or ui_tests. In fact, it might be a good idea to go
ahead
> and add it to at least browser_tests since that's one place debugging would
> really be needed.

It would be nice if we could just blanket-enable or disable it for all binaries.
 I will look into it.