Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3007)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_controller.mm

Issue 6969009: Reduced the lifetime of DownloadCreateInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Stupid clang! Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/gtk/download/download_item_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/download/download_item_controller.mm
diff --git a/chrome/browser/ui/cocoa/download/download_item_controller.mm b/chrome/browser/ui/cocoa/download/download_item_controller.mm
index 6d9290132ee87c23e34b9a431a599d6a5fd8c554..4b185aed2226f4a7079409830b7f6071f44e0497 100644
--- a/chrome/browser/ui/cocoa/download/download_item_controller.mm
+++ b/chrome/browser/ui/cocoa/download/download_item_controller.mm
@@ -171,7 +171,7 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
// The dangerous download label, button text and icon are different under
// different cases.
- if (downloadModel->download()->danger_type() ==
+ if (downloadModel->download()->GetDangerType() ==
DownloadItem::DANGEROUS_URL) {
// Safebrowsing shows the download URL leads to malicious file.
alertIcon = rb.GetNativeImageNamed(IDR_SAFEBROWSING_WARNING);
@@ -180,7 +180,7 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
confirmButtonTitle = l10n_util::GetNSStringWithFixup(IDS_SAVE_DOWNLOAD);
} else {
// It's a dangerous file type (e.g.: an executable).
- DCHECK_EQ(downloadModel->download()->danger_type(),
+ DCHECK_EQ(downloadModel->download()->GetDangerType(),
DownloadItem::DANGEROUS_FILE);
alertIcon = rb.GetNativeImageNamed(IDR_WARNING);
if (downloadModel->download()->is_extension_install()) {
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/gtk/download/download_item_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698