Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5217)

Unified Diff: chrome/browser/ui/browser.cc

Issue 6969009: Reduced the lifetime of DownloadCreateInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Stupid clang! Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 9501f5a70bb1969c3087da6f1a1160c15ed83c89..89754b32650bc3006766d34775346ec978756162 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -3454,7 +3454,7 @@ void Browser::OnStartDownload(DownloadItem* download, TabContentsWrapper* tab) {
// Don't show content browser for extension/theme downloads from gallery.
if (download->is_extension_install()) {
ExtensionService* service = profile_->GetExtensionService();
- if (service && service->IsDownloadFromGallery(download->url(),
+ if (service && service->IsDownloadFromGallery(download->GetURL(),
download->referrer_url())) {
return;
}
@@ -3471,7 +3471,7 @@ void Browser::OnStartDownload(DownloadItem* download, TabContentsWrapper* tab) {
// For non-theme extensions, we don't show the download animation.
if (download->is_extension_install() &&
- !ExtensionService::IsDownloadFromMiniGallery(download->url()))
+ !ExtensionService::IsDownloadFromMiniGallery(download->GetURL()))
return;
TabContents* current_tab = GetSelectedTabContents();

Powered by Google App Engine
This is Rietveld 408576698