Fallback override

AppCache fallback override. A means of overriding the fallback behavior from the server-side by adding a particular response header. Error responses containing the header/value pair will not trigger the fallback behavior.

  x-chromium-appcache-fallback-override: disallow-fallback

BUG=82066
TEST=appcache_request_handler_unittest.cc
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84734

[jennb, 2011-05-09 20:46:37]

Drive-by as I saw the email thread: Change looks good, but could you add a test?

Thanks.

[michaeln, 2011-05-09 20:52:11]

yup... i'll add a test

[michaeln, 2011-05-09 23:38:09]

added a test

jenn, could you take another look?

[jennb, 2011-05-10 00:13:52]

LGTM if try jobs are green.

http://codereview.chromium.org/6969006/diff/9001/webkit/appcache/appcache_req...
File webkit/appcache/appcache_request_handler_unittest.cc (right):

http://codereview.chromium.org/6969006/diff/9001/webkit/appcache/appcache_req...
webkit/appcache/appcache_request_handler_unittest.cc:97: if
(!has_response_info_)
You could initialize response_code_ to info.headers->response_code() to keep
this method simpler.

http://codereview.chromium.org/6969006/diff/9001/webkit/appcache/appcache_req...
webkit/appcache/appcache_request_handler_unittest.cc:418: int64 cache_id =
kNoCacheId;
These checks seem unnecessary as we've already asserted that !job_ in line 416.

[michaeln, 2011-05-10 00:41:58]

thnx!

http://codereview.chromium.org/6969006/diff/9001/webkit/appcache/appcache_req...
File webkit/appcache/appcache_request_handler_unittest.cc (right):

http://codereview.chromium.org/6969006/diff/9001/webkit/appcache/appcache_req...
webkit/appcache/appcache_request_handler_unittest.cc:97: if
(!has_response_info_)
On 2011/05/10 00:13:53, jennb wrote:
> You could initialize response_code_ to info.headers->response_code() to keep
> this method simpler.

Done.

http://codereview.chromium.org/6969006/diff/9001/webkit/appcache/appcache_req...
webkit/appcache/appcache_request_handler_unittest.cc:418: int64 cache_id =
kNoCacheId;
On 2011/05/10 00:13:53, jennb wrote:
> These checks seem unnecessary as we've already asserted that !job_ in line
416.

removed