Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 6969002: Workaround for open source drivers. (Closed)

Created:
9 years, 7 months ago by jonathan.backer
Modified:
9 years, 7 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Workaround for open source drivers. On current open source drivers (1.9.2.901 intel and radeon pulled from X-edgers PPA), glXGetFBConfigFromVisualSGIX is not working as expected even though glxinfo lists GLX_SGIX_fbconfig as a supported extension. Rather than abort when this function fails, this simple patch tries the second code path provided when glXGetFBConfigFromVisualSGIX is unsupported. BUG=none TEST=by hand on Linux with 3D CSS Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/gfx/gl/gl_surface_glx.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jonathan.backer
FWIW, the buggy drivers for which this code works around are blacklisted. However, the workaround ...
9 years, 7 months ago (2011-05-09 15:26:43 UTC) #1
apatrick_chromium
9 years, 7 months ago (2011-05-09 18:19:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698