Remove some dead code from full-codegen on all platforms.

Remove some dead code from full-codegen on all platforms.


BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=8047

[Kevin Millikin (Chromium), 2011-05-24 12:57:27]

http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:743: ASSERT(mode != Variable::CONST);
This needs a comment that a const declaration of a parameter would be a
redeclaration, and we'd never get here.

http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:744: ASSERT(function != NULL);
I think this is wrong:

function f(x) { var x = arguments[0]; }

Has a declaration of x, rewritten to a property, and not a function.  I think
you'll need to keep

if (function != NULL) {
  ...
}

And just emit no code in the function == NULL cases.

[William Hesse, 2011-05-24 14:21:43]

Suggested changes made.

http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:743: ASSERT(mode != Variable::CONST);
On 2011/05/24 12:57:27, Kevin Millikin wrote:
> This needs a comment that a const declaration of a parameter would be a
> redeclaration, and we'd never get here.

Done.

http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:744: ASSERT(function != NULL);
On 2011/05/24 12:57:27, Kevin Millikin wrote:
> I think this is wrong:
> 
> function f(x) { var x = arguments[0]; }
> 
> Has a declaration of x, rewritten to a property, and not a function.  I think
> you'll need to keep
> 
> if (function != NULL) {
>   ...
> }
> 
> And just emit no code in the function == NULL cases.

Done.

[Kevin Millikin (Chromium), 2011-05-24 14:36:25]

I think you forgot to upload the updated x64 version.

LGTM with the analogous x64 change.

http://codereview.chromium.org/6966033/diff/3001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6966033/diff/3001/src/arm/full-codegen-arm.cc#...
src/arm/full-codegen-arm.cc:749: // A const declaration aliasing a parameter is
a illegal redeclaration.
"a" ==> "an" :)

http://codereview.chromium.org/6966033/diff/3001/src/arm/full-codegen-arm.cc#...
src/arm/full-codegen-arm.cc:752: // Store the function for a function
declaration.
This whole function is doing nothing for a regular var declaration and storing
the function for a function declaration (also initializing to the hole for
constants).  I don't really think a special comment is needed here.

http://codereview.chromium.org/6966033/diff/3001/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):

http://codereview.chromium.org/6966033/diff/3001/src/x64/full-codegen-x64.cc#...
src/x64/full-codegen-x64.cc:718: ASSERT(function != NULL);
You still can't assert this here.