Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 6966033: Remove some dead code from full-codegen on all platforms. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Changed comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 742 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 } else { 753 } else {
754 __ mov(r0, Operand(Smi::FromInt(0))); // No initial value! 754 __ mov(r0, Operand(Smi::FromInt(0))); // No initial value!
755 __ Push(cp, r2, r1, r0); 755 __ Push(cp, r2, r1, r0);
756 } 756 }
757 __ CallRuntime(Runtime::kDeclareContextSlot, 4); 757 __ CallRuntime(Runtime::kDeclareContextSlot, 4);
758 break; 758 break;
759 } 759 }
760 } 760 }
761 761
762 } else if (prop != NULL) { 762 } else if (prop != NULL) {
763 if (function != NULL || mode == Variable::CONST) { 763 // A const declaration aliasing a parameter is an illegal redeclaration.
764 // We are declaring a function or constant that rewrites to a 764 ASSERT(mode != Variable::CONST);
765 // property. Use (keyed) IC to set the initial value. We 765 if (function != NULL) {
766 // cannot visit the rewrite because it's shared and we risk 766 // We are declaring a function that rewrites to a property.
767 // recording duplicate AST IDs for bailouts from optimized code. 767 // Use (keyed) IC to set the initial value. We cannot visit the
768 // rewrite because it's shared and we risk recording duplicate AST
769 // IDs for bailouts from optimized code.
768 ASSERT(prop->obj()->AsVariableProxy() != NULL); 770 ASSERT(prop->obj()->AsVariableProxy() != NULL);
769 { AccumulatorValueContext for_object(this); 771 { AccumulatorValueContext for_object(this);
770 EmitVariableLoad(prop->obj()->AsVariableProxy()->var()); 772 EmitVariableLoad(prop->obj()->AsVariableProxy()->var());
771 } 773 }
772 if (function != NULL) { 774
773 __ push(r0); 775 __ push(r0);
774 VisitForAccumulatorValue(function); 776 VisitForAccumulatorValue(function);
775 __ pop(r2); 777 __ pop(r2);
776 } else { 778
777 __ mov(r2, r0);
778 __ LoadRoot(r0, Heap::kTheHoleValueRootIndex);
779 }
780 ASSERT(prop->key()->AsLiteral() != NULL && 779 ASSERT(prop->key()->AsLiteral() != NULL &&
781 prop->key()->AsLiteral()->handle()->IsSmi()); 780 prop->key()->AsLiteral()->handle()->IsSmi());
782 __ mov(r1, Operand(prop->key()->AsLiteral()->handle())); 781 __ mov(r1, Operand(prop->key()->AsLiteral()->handle()));
783 782
784 Handle<Code> ic = is_strict_mode() 783 Handle<Code> ic = is_strict_mode()
785 ? isolate()->builtins()->KeyedStoreIC_Initialize_Strict() 784 ? isolate()->builtins()->KeyedStoreIC_Initialize_Strict()
786 : isolate()->builtins()->KeyedStoreIC_Initialize(); 785 : isolate()->builtins()->KeyedStoreIC_Initialize();
787 EmitCallIC(ic, RelocInfo::CODE_TARGET, AstNode::kNoNumber); 786 EmitCallIC(ic, RelocInfo::CODE_TARGET, AstNode::kNoNumber);
788 // Value in r0 is ignored (declarations are statements). 787 // Value in r0 is ignored (declarations are statements).
789 } 788 }
(...skipping 3577 matching lines...) Expand 10 before | Expand all | Expand 10 after
4367 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. 4366 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value.
4368 __ add(pc, r1, Operand(masm_->CodeObject())); 4367 __ add(pc, r1, Operand(masm_->CodeObject()));
4369 } 4368 }
4370 4369
4371 4370
4372 #undef __ 4371 #undef __
4373 4372
4374 } } // namespace v8::internal 4373 } } // namespace v8::internal
4375 4374
4376 #endif // V8_TARGET_ARCH_ARM 4375 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698