Issue 6966032: Sanitize enclosing quotes around paths in policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6966032: Sanitize enclosing quotes around paths in policies. (Closed)

Created:
9 years, 7 months ago by pastarmovj

Modified:
9 years, 7 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Sanitize enclosing quotes around paths in policies. BUG=80211 TEST=unit_tests PolicyPathParser* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86807

Patch Set 1 #

Patch Set 2 : Fixed the unit tests. #

Total comments: 1

Patch Set 3 : Fixed the nit. #

Patch Set 4 : Fixed one forgotten copyright header. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
M	chrome/browser/policy/policy_path_parser_mac.mm	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_path_parser_posix.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_path_parser_unittest.cc	View	1 2 3	2 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/policy/policy_path_parser_win.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Sorry for flooding you with review requests but you reviewed the original code and thus ...

9 years, 7 months ago (2011-05-24 12:25:14 UTC) #1

markusheintz_

9 years, 7 months ago (2011-05-26 09:45:23 UTC) #2

LGTM with one nit

http://codereview.chromium.org/6966032/diff/2001/chrome/browser/policy/policy...
File chrome/browser/policy/policy_path_parser_mac.mm (right):

http://codereview.chromium.org/6966032/diff/2001/chrome/browser/policy/policy...
chrome/browser/policy/policy_path_parser_mac.mm:41: if (!result.length())
Nit: I'd prefere (result.length() == 0) here as it's consistent with the other
if condition "> 1".

Same in other files.

Expand Messages | Collapse Messages