Sanitize enclosing quotes around paths in policies.

chrome/browser/policy/policy_path_parser_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/policy_path_parser.h"
 
 #include "base/logging.h"
 #include "base/sys_string_conversions.h"
 
 #import <Cocoa/Cocoa.h>
@@ skipping 20 matching lines @@
 const MacFolderNamesToSPDMaping mac_folder_mapping[] = {
     { kMacUsersDirectory, NSUserDirectory},
     { kMacDocumentsFolderVarName, NSDocumentDirectory}
 };
 
 // Replaces all variable occurrences in the policy string with the respective
 // system settings values.
 FilePath::StringType ExpandPathVariables(
     const FilePath::StringType& untranslated_string) {
   FilePath::StringType result(untranslated_string);
+  if (!result.length())

[markusheintz_, 2011/05/26 09:45:23]

Nit: I'd prefere (result.length() == 0) here as it's consistent with the other
if condition "> 1".

Same in other files.

+    return result;
+  // Sanitize quotes in case of any around the whole string.
+  if (result.length() > 1 &&
+      ((result[0] == '"' && result[result.length() - 1] == '"') ||
+      (result[0] == '\'' && result[result.length() - 1] == '\''))) {
+    // Strip first and last char which should be matching quotes now.
+    result = result.substr(1, result.length() - 2);
+  }
   // First translate all path variables we recognize.
   for (size_t i = 0; i < arraysize(mac_folder_mapping); ++i) {
     size_t position = result.find(mac_folder_mapping[i].name);
     if (position != std::string::npos) {
       NSArray* searchpaths = NSSearchPathForDirectoriesInDomains(
           mac_folder_mapping[i].id, NSAllDomainsMask, true);
       if ([searchpaths count] > 0) {
         NSString *variable_value = [searchpaths objectAtIndex:0];
         result.replace(position, strlen(mac_folder_mapping[i].name),
                        base::SysNSStringToUTF8(variable_value));
@@ skipping 26 matching lines @@
       LOG(ERROR) << "Machine name variable can not be resolved.";
     }
     CFRelease(store);
   }
   return result;
 }
 
 }  // namespace path_parser
 
 }  // namespace policy