Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 6964012: Simple elimination of redundant array-hole checks. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Simple elimination of redundant array-hole checks. If the result of an fast elements load is converted to an untagged representation we can omit the hole check if the value is not used anywhere else except for HChange instructions converting it to an untagged representation since those will deoptimize for the hole value anyway. Committed: http://code.google.com/p/v8/source/detail?r=7827

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -0 lines 1 comment Download
M src/hydrogen-instructions.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 7 months ago (2011-05-09 14:02:36 UTC) #1
Kevin Millikin (Chromium)
9 years, 7 months ago (2011-05-09 14:59:54 UTC) #2
LGTM.

http://codereview.chromium.org/6964012/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/6964012/diff/1/src/hydrogen-instructions.h#new...
src/hydrogen-instructions.h:3258: bool check_hole_value() const;
This should probably have a CamelCase name.  I'd also like it to sound more
obviously like a predicate.  ShouldCheckHoleValue?  MustCheckHoleValue?

Powered by Google App Engine
This is Rietveld 408576698