Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6964012: Simple elimination of redundant array-hole checks. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2366 matching lines...) Expand 10 before | Expand all | Expand 10 after
2377 Register result = ToRegister(instr->result()); 2377 Register result = ToRegister(instr->result());
2378 ASSERT(result.is(elements)); 2378 ASSERT(result.is(elements));
2379 2379
2380 // Load the result. 2380 // Load the result.
2381 __ mov(result, FieldOperand(elements, 2381 __ mov(result, FieldOperand(elements,
2382 key, 2382 key,
2383 times_pointer_size, 2383 times_pointer_size,
2384 FixedArray::kHeaderSize)); 2384 FixedArray::kHeaderSize));
2385 2385
2386 // Check for the hole value. 2386 // Check for the hole value.
2387 __ cmp(result, factory()->the_hole_value()); 2387 if (instr->hydrogen()->check_hole_value()) {
2388 DeoptimizeIf(equal, instr->environment()); 2388 __ cmp(result, factory()->the_hole_value());
2389 DeoptimizeIf(equal, instr->environment());
2390 }
2389 } 2391 }
2390 2392
2391 2393
2392 void LCodeGen::DoLoadKeyedSpecializedArrayElement( 2394 void LCodeGen::DoLoadKeyedSpecializedArrayElement(
2393 LLoadKeyedSpecializedArrayElement* instr) { 2395 LLoadKeyedSpecializedArrayElement* instr) {
2394 Register external_pointer = ToRegister(instr->external_pointer()); 2396 Register external_pointer = ToRegister(instr->external_pointer());
2395 Register key = ToRegister(instr->key()); 2397 Register key = ToRegister(instr->key());
2396 ExternalArrayType array_type = instr->array_type(); 2398 ExternalArrayType array_type = instr->array_type();
2397 if (array_type == kExternalFloatArray) { 2399 if (array_type == kExternalFloatArray) {
2398 XMMRegister result(ToDoubleRegister(instr->result())); 2400 XMMRegister result(ToDoubleRegister(instr->result()));
(...skipping 1906 matching lines...) Expand 10 before | Expand all | Expand 10 after
4305 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset)); 4307 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
4306 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4308 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4307 } 4309 }
4308 4310
4309 4311
4310 #undef __ 4312 #undef __
4311 4313
4312 } } // namespace v8::internal 4314 } } // namespace v8::internal
4313 4315
4314 #endif // V8_TARGET_ARCH_IA32 4316 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698