Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 6962044: Revert 87315 - Revert 87309 - Second attempt to fix linux redux builder (Closed)

Created:
9 years, 6 months ago by Miranda Callahan
Modified:
9 years, 6 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 87315 - Revert 87309 - Second attempt to fix linux redux builder Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error. BUG=None TEST=Builds with and without use_openssl=1 Review URL: http://codereview.chromium.org/7050040 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/7054041 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -43 lines) Patch
M base/base.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/system.gyp View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 7 chunks +7 lines, -7 lines 0 comments Download
M crypto/crypto.gyp View 2 chunks +7 lines, -14 lines 0 comments Download
M net/net.gyp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Miranda Callahan
9 years, 6 months ago (2011-05-31 17:19:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698