Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 7050040: Second attempt to fix linux redux builder (Closed)

Created:
9 years, 6 months ago by joth
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, bulach, Nico
Visibility:
Public.

Description

Second attempt to fix linux redux builder Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error. BUG=None TEST=Builds with and without use_openssl=1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -43 lines) Patch
M base/base.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/system.gyp View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 7 chunks +7 lines, -7 lines 0 comments Download
M crypto/crypto.gyp View 2 chunks +7 lines, -14 lines 0 comments Download
M net/net.gyp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
joth
9 years, 6 months ago (2011-05-31 15:51:05 UTC) #1
Evan Martin
9 years, 6 months ago (2011-05-31 16:01:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698