Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2278)

Unified Diff: chrome/browser/extensions/extension_management_api.h

Issue 6961027: Change event routers from singletons to being owned by the ExtensionService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: asargent and dmazzoni's comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_api.h
diff --git a/chrome/browser/extensions/extension_management_api.h b/chrome/browser/extensions/extension_management_api.h
index f7a75e599351c368f80c9ef9cd415d6b66773980..1cfdc3184dc86a0c8117836ab43cb756a7c780f2 100644
--- a/chrome/browser/extensions/extension_management_api.h
+++ b/chrome/browser/extensions/extension_management_api.h
@@ -6,7 +6,6 @@
#define CHROME_BROWSER_EXTENSIONS_EXTENSION_MANAGEMENT_API_H__
#pragma once
-#include "base/memory/singleton.h"
#include "chrome/browser/extensions/extension_function.h"
#include "content/common/notification_observer.h"
#include "content/common/notification_registrar.h"
@@ -50,18 +49,12 @@ class UninstallFunction : public ExtensionManagementFunction {
class ExtensionManagementEventRouter : public NotificationObserver {
public:
- // Get the singleton instance of the event router.
- static ExtensionManagementEventRouter* GetInstance();
+ explicit ExtensionManagementEventRouter() {}
+ virtual ~ExtensionManagementEventRouter() {}
asargent_no_longer_on_chrome 2011/05/24 18:18:00 same inlining nit here
- // Performs one-time initialization of our singleton.
void Init();
private:
- friend struct DefaultSingletonTraits<ExtensionManagementEventRouter>;
-
- ExtensionManagementEventRouter();
- virtual ~ExtensionManagementEventRouter();
-
// NotificationObserver implementation.
virtual void Observe(NotificationType type,
const NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698