chrome/browser/extensions/extension_management_api.cc - Issue 6961027: Change event routers from singletons to being owned by the ExtensionService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_api.cc

Issue 6961027: Change event routers from singletons to being owned by the ExtensionService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: asargent and dmazzoni's comments Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_management_api.h ('K') | « chrome/browser/extensions/extension_management_api.h ('k') | chrome/browser/extensions/extension_preference_api.h » ('j') | chrome/browser/extensions/extension_webnavigation_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_management_api.cc

diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc

index 0053b1d3a48a60fea7835900faa2f0b9ed91cf00..b70fa579bdb77cb3ca2cdb04a44914eb87f72f14 100644

--- a/chrome/browser/extensions/extension_management_api.cc

+++ b/chrome/browser/extensions/extension_management_api.cc

@@ -248,15 +248,6 @@ bool UninstallFunction::RunImpl() {

return true;

}

-// static

-ExtensionManagementEventRouter* ExtensionManagementEventRouter::GetInstance() {

- return Singleton<ExtensionManagementEventRouter>::get();

-ExtensionManagementEventRouter::ExtensionManagementEventRouter() {}

-ExtensionManagementEventRouter::~ExtensionManagementEventRouter() {}

void ExtensionManagementEventRouter::Init() {

NotificationType::Type types[] = {

NotificationType::EXTENSION_INSTALLED,