Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 6948006: Move copyright and svn mime check presubmit checks to trigger on commit only. (Closed)

Created:
9 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Move copyright and svn mime check presubmit checks to trigger on commit only. The commit bot automagically fixes these issues so the devs don't need to fix these problems TEST=none BUG=none R=dpranke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M presubmit_canned_checks.py View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 7 months ago (2011-05-06 20:34:11 UTC) #1
Dirk Pranke
9 years, 7 months ago (2011-05-06 21:56:20 UTC) #2
LGTM.

I will note, though, that if the code that the commit bot was using to fix the
issues was being run though presubmit instead, you could fix these errors on
upload as well, which seems useful. It's not a big deal, though.

Powered by Google App Engine
This is Rietveld 408576698